Skip to content

chore: make uri a field of MultipartUploadHttpRequestManager instead of a parameter for every method #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: make uri a field of MultipartUploadHttpRequestManager instead of a parameter for every method #3383

wants to merge 1 commit into from

Conversation

@BenWhitehead
Copy link
Collaborator

@BenWhitehead BenWhitehead commented Nov 4, 2025

  • Add FakeHttpServer#getHttpStorageOptions()
  • Update ITMultipartUploadHttpRequestManagerTest to use the new options from the FakeHttpServer

@BenWhitehead
chore: make uri a field of MultipartUploadHttpRequestManager instead …
e7bdf1a 
…of a parameter for every method

* Add FakeHttpServer#getHttpStorageOptions()
* Update ITMultipartUploadHttpRequestManagerTest to use the new options from the FakeHttpServer
@BenWhitehead BenWhitehead requested a review from a team as a code owner November 4, 2025 00:38
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShreyasSinha ShreyasSinha Awaiting requested review from ShreyasSinha

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BenWhitehead